Open
Conversation
It is determined depending on the number of bins in camera offset
…imuth is from the whole run so it will be somewhat different than the value for the first event
the efficiency gammaness cuts were calculated from the whole MC sample and now they are limitted to the event within the range of the FoV offset cuts. The same with theta2 cuts (however those are irrelevant with full-enclosure IRFs). This is useful when one tries to make point-like IRFs from diffuse MCs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #317 +/- ##
=======================================
Coverage 75.79% 75.79%
=======================================
Files 22 22
Lines 2739 2739
=======================================
Hits 2076 2076
Misses 663 663 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is to be merged after #315